Support for SAML 2.0 asynchronous (front-channel) binding for single logout #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnel-slo-v2 SAML Front-Channel Logout
Add SAML Front-Channel Logout UI.
…nnel-slo-v4 Apply Front-Channel Logout UI configurations
JKAUSHALYA
approved these changes
Feb 22, 2019
| import java.util.List; | ||
| import java.util.Set; | ||
|
|
||
| public class Util { |
There was a problem hiding this comment.
IMO without releasing a major version, we cannot remove a public API.
There was a problem hiding this comment.
This API was removed as this component did not get packed in the product
| if ((getTextValue(elem, SAMLSSOConstants.FileBasedSPConfig.FRONT_CHANNEL_LOGOUT)) != null) { | ||
| spDO.setDoFrontChannelLogout(Boolean.valueOf(getTextValue(elem, SAMLSSOConstants.FileBasedSPConfig | ||
| .FRONT_CHANNEL_LOGOUT))); | ||
| if(spDO.isDoFrontChannelLogout()) { |
There was a problem hiding this comment.
Fixed with 1149d97
| "<input type='hidden' name='AuthenticatedIdPs' value='" | ||
| + Encode.forHtmlAttribute(authenticatedIdPs) + "'/>"); | ||
| } | ||
| PrintWriter out = resp.getWriter(); |
There was a problem hiding this comment.
Without writing each and every line to response, it's better to build the whole response and write to output in a single go.
There was a problem hiding this comment.
Fixed with 3bbc008
GDRDABARERA
reviewed
Oct 10, 2019
| @@ -847,4 +849,4 @@ | |||
| <http:address location="https://localhost:9443/services/IdentitySAMLSSOConfigService.IdentitySAMLSSOConfigServiceHttpsEndpoint/"/> | |||
| </wsdl:port> | |||
| </wsdl:service> | |||
| </wsdl:definitions> | |||
| </wsdl:definitions> | |||
There was a problem hiding this comment.
Fixed with 1149d97
GDRDABARERA
reviewed
Oct 10, 2019
| @@ -136,6 +137,42 @@ public static boolean isSingleLogoutEnabled(boolean isSpEdit, SAMLSSOServiceProv | |||
| return false; | |||
| } | |||
|
|
|||
| /** | |||
| * Check front-Channel logout enable and if not enable return false. | |||
| * @param isSpEdit Operation on service provider, create or edit. | |||
There was a problem hiding this comment.
Put a space after the description line, to make it clean to read
There was a problem hiding this comment.
Fixed with 1149d97
sachiniWettasinghe
added a commit
to sachiniWettasinghe/identity-inbound-auth-saml
that referenced
this pull request
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
Fixes wso2/product-is#4038