Use KeyStoreManager to get primary keystore #2577
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2577 +/- ##
=============================================
- Coverage 55.45% 38.08% -17.38%
+ Complexity 8022 5295 -2727
=============================================
Files 632 584 -48
Lines 45888 44392 -1496
Branches 7034 6525 -509
=============================================
- Hits 25449 16908 -8541
- Misses 16722 25135 +8413
+ Partials 3717 2349 -1368
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hwupathum
force-pushed
the
pkcs12
branch
3 times, most recently
from
bd1ceaa
to
0c7a832
Compare
| @@ -228,6 +221,8 @@ protected Map<String, Object> initialValue() { | |||
| keyStoreManager.when(() -> KeyStoreManager.getInstance(anyInt())).thenReturn(mockKeyStoreManager); | |||
| lenient().when(mockKeyStoreManager.getKeyStore("foo-com.jks")).thenReturn( | |||
| getKeyStoreFromFile("foo-com.jks", "foo.com")); | |||
| lenient().when(mockKeyStoreManager.getPrimaryKeyStore()).thenReturn( | |||
There was a problem hiding this comment.
Why to we include file retrieval in the test ?
There was a problem hiding this comment.
Although we are moving to PKCS12 keystores, still we have JKS keystores in other repositories for unit tests
|
PR builder started |
|
PR builder completed |
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11054703085
Proposed changes in this pull request
Related PRs
Related Issues