Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pre Issue Access Token action execution issue when previous token grant type is refresh_token #2562

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

ashanthamara
Copy link
Contributor

@ashanthamara ashanthamara commented Aug 28, 2024

Proposed changes in this pull request

  • When the previous token is also taken from the refresh_token grant type, the action execution didn't happen since it only checked the authorization_code and password grant types. Due to that reason action execution not performed after the first refresh of the token.
  • Modified action execution triggering logic to allow tokens with grant_type refresh_token in RefreshGrantHandler. After this action will be triggered for the refreshing a token issued by refresh_token grant.

When should this PR be merged

  • Soon

Follow up actions

  • Bump version in Product

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/10602159996

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/10602159996
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/10602159996

@ashanthamara ashanthamara merged commit c1e7473 into wso2-extensions:master Aug 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants