Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use application tenant domain to retrieve client app #2557

Conversation

mpmadhavig
Copy link
Contributor

@mpmadhavig mpmadhavig commented Aug 23, 2024

Proposed changes in this pull request

When retrieving an application, use the tenant domain specified in the access token, instead of the user's tenant domain.

@mpmadhavig mpmadhavig force-pushed the feature-enable-disable-config-api branch from d97c5b5 to 4e56039 Compare August 23, 2024 10:10
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/10523947074

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/10523947074
Status: failure

@mpmadhavig mpmadhavig force-pushed the feature-enable-disable-config-api branch from f51c33a to 87dc56a Compare August 23, 2024 11:17
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/10523947074

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/10523947074
Status: failure

@mpmadhavig mpmadhavig force-pushed the feature-enable-disable-config-api branch from 5a92755 to 1b2aa8c Compare August 23, 2024 20:21
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/10523947074

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/10523947074
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/10523947074

tenantDomain);
omitUsernameInIntrospectionRespForAppTokens = oAuthApp.isOmitUsernameInIntrospectionRespForAppTokens();

return Boolean.TRUE.equals(oAuthAppDO.isOmitUsernameInIntrospectionRespForAppTokens());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cant we just return the oAuthAppDO.isOmitUsernameInIntrospectionRespForAppTokens()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can. But to be safe used this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oAuthAppDO.isOmitUsernameInIntrospectionRespForAppTokens() never be null right? then its ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants