Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce extension point for building requests to authorize EP #2127

Merged
merged 15 commits into from
Aug 15, 2023
Merged

Introduce extension point for building requests to authorize EP #2127

merged 15 commits into from
Aug 15, 2023

Conversation

Yoshani
Copy link
Contributor

@Yoshani Yoshani commented Aug 2, 2023 •
edited
Loading

Proposed changes in this pull request

This PR introduces:

  • An extension point for building requests to authorize EP.
  • Validations for PAR endpoint
    • validate input parameters
    • validate repeated parameters
    • validations from authorize EP

Related Issues

@Yoshani Yoshani mentioned this pull request Aug 2, 2023
Closed
5 tasks
@Yoshani Yoshani force-pushed the par-improvements branch 2 times, most recently from 041758b to 9bf56fb Compare August 4, 2023 02:59
Thumimku
Thumimku reviewed Aug 4, 2023
View reviewed changes
components/org.wso2.carbon.identity.oauth.endpoint/pom.xml
@@ -332,7 +332,7 @@
<limit implementation="org.jacoco.report.check.Limit">
<counter>COMPLEXITY</counter>
<value>COVEREDRATIO</value>
<minimum>0.53</minimum>
<minimum>0.52</minimum>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason to reduce the code cover ratio?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests have not been added covering the PAR implementation. Will be addressed in a new PR.

@Yoshani
Copy link
Contributor Author

Yoshani commented Aug 7, 2023 •
edited
Loading

Have proper parent Exception for ParAuthFailureException, check IdentityException

@Yoshani Yoshani marked this pull request as draft August 14, 2023 02:58
@Yoshani Yoshani marked this pull request as ready for review August 14, 2023 07:53
janakamarasena
janakamarasena approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@janakamarasena janakamarasena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on that a PR with unit tests will be sent soon for this.

@chamathns chamathns merged commit 161a006 into wso2-extensions:master Aug 15, 2023
1 check passed
@Yoshani
Copy link
Contributor Author

Yoshani commented Aug 16, 2023

Approved based on that a PR with unit tests will be sent soon for this.

Unit tests added with: #2134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravinduramesh ravinduramesh ravinduramesh left review comments

@chamathns chamathns chamathns left review comments

@Thumimku Thumimku Thumimku left review comments

@sahandilshan sahandilshan sahandilshan left review comments

@sandushi sandushi sandushi left review comments

@ThaminduR ThaminduR ThaminduR left review comments

@janakamarasena janakamarasena janakamarasena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Yoshani @janakamarasena @ravinduramesh @chamathns @Thumimku @sahandilshan @sandushi @ThaminduR