Improve resolving subject claim when user resides in ancestor organization. #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/5314223215
AnuradhaSK
reviewed
Jun 21, 2023
...on.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth2/token/AccessTokenIssuer.java
Outdated
Show resolved
Hide resolved
AnuradhaSK
reviewed
Jun 21, 2023
...on.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth2/token/AccessTokenIssuer.java
Outdated
Show resolved
Hide resolved
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/5343875330
AnuradhaSK
reviewed
Jun 29, 2023
...uth/src/main/java/org/wso2/carbon/identity/oauth2/internal/OAuth2ServiceComponentHolder.java
Outdated
Show resolved
Hide resolved
AnuradhaSK
reviewed
Jun 29, 2023
...on.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth2/token/AccessTokenIssuer.java
Show resolved
Hide resolved
AnuradhaSK
reviewed
Jun 29, 2023
...on.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth2/token/AccessTokenIssuer.java
Outdated
Show resolved
Hide resolved
sadilchamishka
force-pushed
the
improve-resolve-subject-identifier-logic
branch
from
e787c87
to
049eee8
Compare
AnuradhaSK
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
The subject claim for the given user ID can only be resolved if user exist in that tenant(organization). Therefore the logic is improved to first check the user's existence. If user not found, user should be resolved from the ancestor organizations before trying to resolve the subject claim.