Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Fastlane::Helper::Ios::GitHelper.commit_version_bump #525

Open
mokagio opened this issue Oct 30, 2023 · 0 comments
Open

Deprecate Fastlane::Helper::Ios::GitHelper.commit_version_bump #525

mokagio opened this issue Oct 30, 2023 · 0 comments

Comments

@mokagio
Copy link
Contributor

mokagio commented Oct 30, 2023

The helper method relies on the PROJECT_ROOT_FOLDER environment variable, which is no longer meant to be used and has been removed by client apps such as WordPress iOS, wordpress-mobile/WordPress-iOS#21859.

Looking at it today, commit_version_bump seems redundant. It DRYs the message and paths for the committing a version bump, but is it actually necessary to have that logic DRYed in a library when it's possible to achieve the same result with a method, e.g. see wordpress-mobile/WordPress-iOS@f886436, within the project's Fastfile?

I propose we deprecate the helper, or at and schedule it for removal on the next major version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant