Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read FASTLANE_SKIP_TOOLKIT_UPDATE_CHECK in check_for_toolkit_updates action #483

Open
mokagio opened this issue May 16, 2023 · 0 comments
Open

Comments

@mokagio
Copy link
Contributor

mokagio commented May 16, 2023

Currently, projects such as WordPress iOS use check_for_toolkit_updates in combination with the FASTLANE_SKIP_TOOLKIT_UPDATE_CHECK environment variable as a way to bypass the process. E.g.

check_for_toolkit_updates unless is_ci || ENV['FASTLANE_SKIP_TOOLKIT_UPDATE_CHECK']

Having the env var spelled out at the project level is convenient for discoverability, but I wonder if we would be better served "at scale" if the command itself read that env var, and possibly the is_ci value, too.

Doing so would streamline adopting the command ("action", really) to simply calling it.

We could compensate for discoverability by:

  • Adding a message as part of the output informing users of the env var existence
  • Adding a force parameter to bypass those internal checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant