What's a good value for RSpec example length?

[mokagio]

When working on #242, I added some tests and RuboCop warned me they should have been 5 lines or less.

RSpec/ExampleLength: Example has too many lines [7/5].

I addressed the violation with a cheap trick.

I'm all in for having short methods actually, I do really like the Sandi Metz rules. But, in the context of that commit, I feel like I didn't make the test more readable.

I can see two options:

• Relax the rule to acknowledge the current state of this codebase, where there's a lot of setup and mocking required for testing
• Stick with the rule, and do our best to work within it in a way that makes the codebase better.

[mokagio]

I feel like I didn't make the test more readable.

As an aside, something else I could have done was extracting that setup logic in a method so that it would have been a one liner all in the example and I would have satisfied the RuboCop requirement 🤔