Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versioning branches or tags #5

Open
1 task
puntope opened this issue May 20, 2022 · 4 comments
Open
1 task

Add versioning branches or tags #5

puntope opened this issue May 20, 2022 · 4 comments
Labels
type: enhancement The issue is a request for an enhancement.

Comments

@puntope
Copy link
Contributor

puntope commented May 20, 2022

User story

As a developer I want to refer to this repo using versioned tags instead of "trunk" branch.

How to reproduce the problem

For referring to this repo we should add the branch trunk.

Describe the solution you'd like

Use a release version like WooCommerce or other repos in do.

Acceptance criteria

@puntope puntope added the type: enhancement The issue is a request for an enhancement. label May 20, 2022
@tomalec
Copy link
Member

tomalec commented May 23, 2022

WDYT of using Nx (to be consistent with woocommerce/woocommerce stack) and https://github.com/jscutlery/semver plugin?
So we could simply do something like:

nx run storybook:version --releaseAs=minor

To do version bumps, git commit, tag ([email protected]) & push

@puntope
Copy link
Contributor Author

puntope commented May 25, 2022

WDYT of using Nx (to be consistent with woocommerce/woocommerce stack)

I guess is same as NPX? Glad to use it, looks cool and I wanted to give it a go for a long time. So 👍 for it

and https://github.com/jscutlery/semver plugin?

Never used it. (Neither heard about it) Wouldn't be enough with git flow?

@tomalec
Copy link
Member

tomalec commented May 26, 2022

I guess is same as NPX?

not really npx (at least the one I know of) is an npm package that gives a command to execute binaries. While Nx is a rather big tool to setup a monorepo workflows.

Wouldn't be enough with git flow?

I don't think git flow works for monorepos out of the box. But maybe there is a way to use git flow directly with Nx. I don't know, As I've never used Nx or jscutlery/semver

@tomalec
Copy link
Member

tomalec commented May 30, 2022

Maybe we can wait with Nx setup for woocommerce/woocommerce#33079 as if Woo will move away to another tool, I'd use here the same.

tomalec added a commit that referenced this issue Jun 7, 2022
instead of relative FS path, to make the `jsdoc` package installable elsewhere.

Related to #5

Address #10 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants