Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js actions deprecated in workflow runs #2218

Closed
mikkamp opened this issue Jan 25, 2024 · 1 comment · Fixed by #2404
Closed

Node.js actions deprecated in workflow runs #2218

mikkamp opened this issue Jan 25, 2024 · 1 comment · Fixed by #2404
Assignees

Comments

@mikkamp
Copy link
Contributor

mikkamp commented Jan 25, 2024

Describe the issue:

Just logging warnings that show up when running workflows:

image

As far as I can see we don't necessarily need to make the extension compatible with this Node version, but only have the action run with the newer node version. For actions like woocommerce/grow/get-plugin-releases@actions-v1 that should be possible to switch to a newer node version. For actions/checkou@v3 it should be enough tot switch to v4 as long as there are no breaking changes.

@mikkamp
Copy link
Contributor Author

mikkamp commented Apr 24, 2024

This is being resolved in woocommerce/grow#108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants