Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly redundant Sleep #28

Open
Kek5chen opened this issue May 6, 2024 · 1 comment
Open

Possibly redundant Sleep #28

Kek5chen opened this issue May 6, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request thinking This is currently being pondered about

Comments

@Kek5chen
Copy link
Contributor

Kek5chen commented May 6, 2024

tokio::time::sleep(std::time::Duration::from_secs(1)).await;

Why is there a sleep here? Can this be removed? The task is done at that point and logs should have sunk into the remote logger so finish can be called safely right away, or am I missing something?

@Kek5chen Kek5chen added the question Further information is requested label May 6, 2024
@Kek5chen
Copy link
Contributor Author

We're all a bit unsure but it seems to be some ancient logging thing from etcd that was used to protect against some desynchronized state.

Might remove and test.

@Kek5chen Kek5chen added enhancement New feature or request and removed question Further information is requested labels May 13, 2024
@Kek5chen Kek5chen changed the title Unexplained Sleep Possibly redundant Sleep May 13, 2024
@Kek5chen Kek5chen added the thinking This is currently being pondered about label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request thinking This is currently being pondered about
Projects
None yet
Development

No branches or pull requests

2 participants