Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the PSBT returned by the Specter doesn't contain any signature #14

Open
darosior opened this issue Feb 1, 2023 · 0 comments

Comments

@darosior
Copy link
Member

darosior commented Feb 1, 2023

Otherwise this logic would be wrong:

async-hwi/src/specter.rs

Lines 116 to 128 in 4cad3dc

// Psbt returned by specter wallet has all unnecessary fields removed,
// only global transaction and partial signatures for all inputs remain in it.
// In order to have the full Psbt, the partial_sigs are extracted and appended
// to the original psbt.
let mut has_signed = false;
for i in 0..new_psbt.inputs.len() {
if !new_psbt.inputs[i].partial_sigs.is_empty() {
has_signed = true;
psbt.inputs[i]
.partial_sigs
.append(&mut new_psbt.inputs[i].partial_sigs)
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant