Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine EditPhrasesKeyboardFragment and AddPhraseKeyboardFragment #496

Open
kaffn8ed27 opened this issue Feb 7, 2024 · 0 comments
Open
Assignees

Comments

@kaffn8ed27
Copy link
Collaborator

kaffn8ed27 commented Feb 7, 2024

These fragments are both subclasses of EditKeyboardFragment, and have very similar functionality. EditPhrasesKeyboardFragment should be able to handle both jobs, with the following changes:

  • Add a boolean nav arg that identifies whether a phrase is being added (a var already exists in the fragment for this, but its value is always false)
  • Pass the appropriate value for said nav arg when editing vs. adding a new phrase (tapping existing phrase or using + button)
  • Alter nav graph so that the + button on EditCategoryPhrasesFragment opens an Edit fragment instead of an Add fragment
  • Add the function addPhrase to EditPhrasesViewModel: see AddPhraseViewModel
  • Probably replace use of deprecated ILegacyCategoriesAndPhrasesRepository in PhrasesUseCase (may be best broken out into future work)
@lauren-ahart lauren-ahart self-assigned this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants