Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content model and 'what' to render for stylable <select> elements #10317

Open
scottaohara opened this issue May 2, 2024 · 20 comments · May be fixed by #10586
Open

Content model and 'what' to render for stylable <select> elements #10317

scottaohara opened this issue May 2, 2024 · 20 comments · May be fixed by #10586
Labels
accessibility Affects accessibility needs concrete proposal Moving the issue forward requires someone to figure out a detailed plan topic: forms

Comments

@scottaohara
Copy link
Collaborator

scottaohara commented May 2, 2024

This is a follow on to #10310 to move discussion on what to do about the potential content models for styleable selects, and its current/proposed directly supported children/descendants (option, optgroup, hr, button, datalist). Additionally, I'd expect this discussion could also cover what may be rendered in a select or not, regardless of whether the elements are parsed out or not. (as was noted in the other issue, one can get around the parser and inject elements into a select - but they don't actually render. that's clearly not the intent for what changing the parser would do, continue to not have elements render - but maybe some still shouldnt?)

One reason to start this discussion is to also determine potential use cases / author intent for content that extends beyond the current content model. For instance, someone wanted to provide a description to an option element - they might think to intervene options with divs or paragraph elements to do this:

...
<option>Orange</option>
<p>A type of fruit, or color... context matters</p>
<option>...

but that isn't really enough to just allow the paragraph in there - there needs to be an association between the paragraph and the option so that the paragraph's content can be relayed via the a11y api as the options description. And putting the paragraph within the option means it'd contribute to its accessible name (undesired).

So, is it enough to just allow any content in and have authors hook it up themselves. Or have HTML determine new definitions for how elements work together in this context? Or is it really a new supporting element that is needed, and allowing main, article, video, iframe into the mix is just noise and potential for author error that didn't exist since the parser didn't allow these things before?

I hope this serves as enough to get this ball rolling.

@annevk annevk added accessibility Affects accessibility topic: forms needs concrete proposal Moving the issue forward requires someone to figure out a detailed plan labels May 3, 2024
@annevk
Copy link
Member

annevk commented May 3, 2024

To be clear, #10310 was to discuss a specific subset of #9799. What ends up getting rendered is really a function of the appearance property and is already tracked by its own issue over in the CSS WG: w3c/csswg-drafts#10028 & w3c/csswg-drafts#5998.

I think an accessible select will always need to have text-based options, essentially. Not just for accessibility, but also for platforms that opt not to support the custom rendering. When you create a tree that one cannot derive text-based options from (and thus doesn't render anything with appearance:auto instead of appearance:base-select) that should essentially be a non-conforming.

josepharhar added a commit to josepharhar/html that referenced this issue Jul 16, 2024
This needs refinement after accessibility semantics/constraints are
figured out: whatwg#10317
josepharhar added a commit to josepharhar/html that referenced this issue Jul 17, 2024
This needs refinement after accessibility semantics/constraints are
figured out: whatwg#10317
josepharhar added a commit to josepharhar/html that referenced this issue Jul 31, 2024
This needs refinement after accessibility semantics/constraints are
figured out: whatwg#10317
josepharhar added a commit to josepharhar/html that referenced this issue Aug 1, 2024
This needs refinement after accessibility semantics/constraints are
figured out: whatwg#10317
@josepharhar
Copy link
Contributor

My draft spec has a proposed updated content model here: #10548

The gist of the changes:

<select>

  • Either one of the following:
    • Zero or more <option>s, <optgroup>s, <hr>s, script-supporting elements, <noscript>s, <div>s, <span>s, and “decorative images”.
    • One <datalist>
  • Zero or one <button>

<datalist>

  • Either: phrasing content if not the child of a select element.
  • Or: zero or more <option>s, <optgroup>s, <hr>s, script-supporting elements, <noscript>s, <div>s, <span>s, and “decorative images”.

<optgroup>

  • Zero or more <option>s, <hr>s, script-supporting elements, <noscript>s, <div>s, <span>s, and “decorative images”.
  • Zero or one <legend>.

<option>

  • If the element has a label attribute and a value attribute: Nothing
  • If the element has a label attribute but no value attribute: Text
  • If the element has no label attribute: Text, script-supporting elements, <noscript>s, <div>s, <span>s, and “decorative images”.

Decorative images:

  • <img> with alt=””
  • <svg> with aria-hidden

@annevk
Copy link
Member

annevk commented Aug 13, 2024

Why would we only allow decorative images? I think we should make alt="something" work. People will want to be able to replace option text with images.

josepharhar added a commit to josepharhar/html that referenced this issue Aug 13, 2024
This needs refinement after accessibility semantics/constraints are
figured out: whatwg#10317
@scottaohara
Copy link
Collaborator Author

scottaohara commented Aug 13, 2024

we had discussed images with alternative text being allowed. i think that might just be a miss. We had talked about how it could be problematic if people used images without alternative text or visible text in the option - and how that'd be an issue.

but i know there was also discussion about needing to potentially address your previous comment.

I think an accessible select will always need to have text-based options, essentially. Not just for accessibility, but also for platforms that opt not to support the custom rendering.

with your latest comment, are you implying it might be ok if image has alternative text, then such platforms could render the alt text instead of the image? if so that'd be great. i was worried that if a platform decided not to render the image, that the whole image, including alt text, would be dropped.

@domenic
Copy link
Member

domenic commented Aug 14, 2024

Relatedly, I think having authoring conformance requirements depend on ARIA seems a bit sketchy? ARIA is supposed to be used as a means of interfacing with AT, and not affect semantics or document conformance.

@annevk
Copy link
Member

annevk commented Aug 14, 2024

@scottaohara right, it's called "replacement text" for a reason. I don't see why we couldn't use that.

@scottaohara
Copy link
Collaborator Author

scottaohara commented Aug 14, 2024

@annevk excellent, seems we're on the same page then. again, i think that's a mistake in relaying what had been discussed. an option should absolutely be able to contain non-decorative images. The only requirement with graphics being that if they are the only content of an option, they must have alternative text.

the mention of decorative images was supposed to be in regard to if the graphic was a direct child of a select element (used outside of an option), not if it was a child of an option. cc @josepharhar

@domenic that's fair, and if not for the fact that aria-hidden=true is the primary author guidance for how to mark svgs as decorative, then the use of aria would have been avoided. but maybe it makes sense to reverse the way this is being talked about. lean more into where there would be author requirements to provide alternative text for graphics, rather than requirements about marking graphics as decorative/presentational.

@josepharhar
Copy link
Contributor

Thanks for the discussion!

So it sounds like I should keep the content model the way it is but also remove the requirement of having alt='' or aria-hidden=true, and then add another requirement for this:

The only requirement with graphics being that if they are the only content of an option, they must have alternative text.

Anything I'm missing? If not then I can go update the content model in the draft spec.

@domenic
Copy link
Member

domenic commented Aug 16, 2024

The only requirement with graphics being that if they are the only content of an option, they must have alternative text.

I don't think we need a specific requirement for this. There are many elements in the spec which don't make very much sense if they're empty (e.g., only whitespace, or only a non-alt image, or only <audio>). For example <p> or <em>. I don't believe we call out such restrictions on their contents.

@annevk
Copy link
Member

annevk commented Aug 16, 2024

For the title element we do call out non-whitespace text as content model, but for the option element without label attribute we only say text. But then we define text as potentially being nothing. We might not be as good about this as we should be?

@zcorpan
Copy link
Member

zcorpan commented Aug 19, 2024

We have "palpable content", but it might not be correct for option (for example an img with empty alt counts as palpable content).

Right now https://html.spec.whatwg.org/#the-option-element has

If the element has no label attribute and is not a child of a datalist element: Text that is not inter-element whitespace.

I think the intent is to catch the mistake where the contents of option is used as its value.

Should alt text be included in the submitted value? That would be a normative change, but maybe it's not a web compat problem (since you can't easily use images in option and they are ignored today). If so, https://html.spec.whatwg.org/#dom-option-text needs to be changed, and maybe the content model can just say that https://html.spec.whatwg.org/#concept-option-value must be non-empty (when in a select and no label attribute)

@josepharhar
Copy link
Contributor

Should alt text be included in the submitted value? That would be a normative change, but maybe it's not a web compat problem (since you can't easily use images in option and they are ignored today).

I feel like the only case where making alt text the submitted value make sense is if there is no other text in the option element and the option element also doesn't have the value attribute. Wouldn't it make more sense to put a value attribute on the option as well?

For the title element we do call out non-whitespace text as content model, but for the option element without label attribute we only say text. But then we define text as potentially being nothing. We might not be as good about this as we should be?

This sounds in favor of including the "if they are the only content of an option, they must have alternative text" requirement. Do you think we should have that requirement?

@scottaohara
Copy link
Collaborator Author

i don't see the downside of calling this out. Even if just briefly and cross linking over to https://html.spec.whatwg.org/multipage/images.html#alt for the more detailed requirements for when an alt is necessary.

@annevk
Copy link
Member

annevk commented Aug 22, 2024

Wouldn't it make more sense to put a value attribute on the option as well?

It seems cumbersome if you would otherwise not have to do that. Since we already have a custom iterator to determine the text content we might as well handle img elements explicitly going forward.

Additionally, we have environments where we need to display the pure text version and that pure text version should be roughly the same as what AT sees I think and not necessarily reflect the submitted value (which can be nonsensical as far as an end user is concerned).

@josepharhar
Copy link
Contributor

It seems cumbersome if you would otherwise not have to do that

that pure text version should be roughly the same as what AT sees I think and not necessarily reflect the submitted value (which can be nonsensical as far as an end user is concerned).

It sounds like you're in favor of including alt text in the submitted value. Is that correct?

the mention of decorative images was supposed to be in regard to if the graphic was a direct child of a select element (used outside of an option), not if it was a child of an option.

This sounds in favor of including the "if they are the only content of an option, they must have alternative text" requirement. Do you think we should have that requirement?

i don't see the downside of calling this out.

So it sounds like if the image it outside of the option it must not have alt text, and if its inside the image it must have alt text. I'm going to add this to the spec.

Relatedly, I think having authoring conformance requirements depend on ARIA seems a bit sketchy? ARIA is supposed to be used as a means of interfacing with AT, and not affect semantics or document conformance.

if not for the fact that aria-hidden=true is the primary author guidance for how to mark svgs as decorative, then the use of aria would have been avoided

For svgs, can we just make aria-hidden get applied automatically as part of the accessibility mappings when needed? Also, how is alt text supposed to be put on svgs in order to follow the requirement that it must have alt text when used inside an option element?

josepharhar added a commit to josepharhar/html that referenced this issue Aug 28, 2024
This needs refinement after accessibility semantics/constraints are
figured out: whatwg#10317
@scottaohara
Copy link
Collaborator Author

just talked with @josepharhar about this, and per the feedback in this thread we are instead thinking to drop the explicit mention of decorative images from the content model entirely.

Rather, author guidance can be provided in examples and notes, referencing back to existing spec content about the alt attribute, and explaining why it is important to mark graphics as either decorative or informative. Per Domenic's point, there is no special author requirements for other elements, like hyperlinks or the button element, that if you use only an <img src=... alt=""> as their contents then that would make non-conforming HTML. But a11y-specific checkers and WCAG success criteria exist and can catch these sorts of problems.

The only way I could still see graphics being mentioned in the content model, is in regard to needing a value to submit - so that an option like <option><img src=# alt></option> would return something. but again, very happy to just make that into an example if people think this scenario would be covered by the existing content model allowances?

josepharhar added a commit to josepharhar/html that referenced this issue Aug 28, 2024
This PR updated the content model for the <select>, <option>, and
<optgroup> elements in support of customizable <select>.

Fixes whatwg#10317
@josepharhar josepharhar linked a pull request Aug 28, 2024 that will close this issue
5 tasks
josepharhar added a commit to josepharhar/html that referenced this issue Aug 28, 2024
This PR updated the content model for the <select>, <option>, and
<optgroup> elements in support of customizable <select>.

Fixes whatwg#10317
@josepharhar
Copy link
Contributor

Thanks scott!! I created a spec PR here: #10586

@yisibl
Copy link

yisibl commented Aug 29, 2024

Are form elements like <input> currently supported?

There is a use case in Ant design. https://ant-design.antgroup.com/~demos/select-demo-custom-dropdown-menu

image

@annevk
Copy link
Member

annevk commented Aug 29, 2024

It sounds like you're in favor of including alt text in the submitted value. Is that correct?

I think I would expect it to influence the text getter and therefore both the "label" and "value". (Although we should probably not define the latter two by directly invoking the text getter as we do today as that's kinda bogus.)

@scottaohara
Copy link
Collaborator Author

Thanks scott!! I created a spec PR here: #10586

thanks Joey. That looks like it's going in the right direction to me. And so long as it's good with everyone else, then when the rest of the spec updates are in a good place, we can maybe co-author some examples/notes as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Affects accessibility needs concrete proposal Moving the issue forward requires someone to figure out a detailed plan topic: forms
Development

Successfully merging a pull request may close this issue.

8 participants
@past @zcorpan @domenic @annevk @yisibl @scottaohara @josepharhar and others