Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI not working when using latest git head #162

Closed
ttytm opened this issue Aug 18, 2023 · 2 comments
Closed

WebUI not working when using latest git head #162

ttytm opened this issue Aug 18, 2023 · 2 comments

Comments

@ttytm
Copy link
Member

ttytm commented Aug 18, 2023

Calling C/C++ functions form JS does not work.

When trying to run the call_c_from_js/call_cpp_from_js examples, the functions should print their results to the terminal, but they do not.

Checking the browser console, the error is:

Uncaught ReferenceError: webui_fn is not defined
    at HTMLButtonElement.onclick ((index):22:58)

The examples work checking out version 2.3.0

git checkout tags/2.3.0

I think it's a high priority to fix this before releasing another version.

@ttytm
Copy link
Member Author

ttytm commented Aug 18, 2023

It looks like it stopped working after #131

@hassandraga
Copy link
Member

webui_fn() is now webui.call() suggested by @JOTSR . It's a break change. But it's a small deal as this is our only JS API.

Examples updated (3133bcb).
Website update (https://webui.me/docs/2.4.0/#/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants