Support for 2.5 #10
Open
Support for 2.5 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a great PR, Thank you for your contribution 👍 |
|
Please resolve the clippy and rustfmt errors please! Otherwise it looks good. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I just wanted to add some features and then it went somehow out of control and I rewrote everything. 😆
This PR adds:
WindowandEventstructs for easy library usageUnfortunately this will break the official webui docs but I don't see them as a good place for wrapper documentation anyways. They should introduce a new user with examples and use cases for each wrapper and then link to their generated docs.
Of course documentation and testing is needed but I have compiled and used this library on windows and linux.
What do you think?