From 364183cfd895ead6b123d06fc0853dcd165ecd36 Mon Sep 17 00:00:00 2001 From: Lachlan Roberts Date: Wed, 29 May 2024 16:09:59 +1000 Subject: [PATCH] fix other checkstyle warnings Signed-off-by: Lachlan Roberts --- .../web/reactive/socket/client/JettyWebSocketClient.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/spring-webflux/src/main/java/org/springframework/web/reactive/socket/client/JettyWebSocketClient.java b/spring-webflux/src/main/java/org/springframework/web/reactive/socket/client/JettyWebSocketClient.java index ae2b185fe4ea..bc770de68147 100644 --- a/spring-webflux/src/main/java/org/springframework/web/reactive/socket/client/JettyWebSocketClient.java +++ b/spring-webflux/src/main/java/org/springframework/web/reactive/socket/client/JettyWebSocketClient.java @@ -18,6 +18,7 @@ import java.io.IOException; import java.net.URI; +import java.util.Objects; import java.util.concurrent.atomic.AtomicReference; import org.eclipse.jetty.client.Request; @@ -79,7 +80,7 @@ public Mono execute(URI url, @Nullable HttpHeaders headers, WebSocketHandl headers.keySet().forEach(header -> upgradeRequest.setHeader(header, headers.getValuesAsList(header))); } - AtomicReference handshakeInfo = new AtomicReference<>(); + final AtomicReference handshakeInfo = new AtomicReference<>(); JettyUpgradeListener jettyUpgradeListener = new JettyUpgradeListener() { @Override public void onHandshakeResponse(Request request, Response response) { @@ -92,10 +93,10 @@ public void onHandshakeResponse(Request request, Response response) { Sinks.Empty completion = Sinks.empty(); JettyWebSocketHandlerAdapter handlerAdapter = new JettyWebSocketHandlerAdapter(handler, session -> - new JettyWebSocketSession(session, handshakeInfo.get(), DefaultDataBufferFactory.sharedInstance, completion)); + new JettyWebSocketSession(session, Objects.requireNonNull(handshakeInfo.get()), DefaultDataBufferFactory.sharedInstance, completion)); try { this.client.connect(handlerAdapter, url, upgradeRequest, jettyUpgradeListener) - .exceptionally((throwable) -> { + .exceptionally(throwable -> { // Only fail the completion if we have an error // as the JettyWebSocketSession will never be opened. completion.tryEmitError(throwable);