From b43d0fb275862f3a084ff45dff3cd840ba3f3807 Mon Sep 17 00:00:00 2001
From: Peter Kotwicz <pkotwicz@chromium.org>
Date: Thu, 3 Oct 2024 10:30:45 -0700
Subject: [PATCH] [Digital Credentials WPT Tests] Fix tests some more

This CL:
- Changes the exception thrown when the digital credentials API is
invoked when the page does not have transient user activation to
NotAllowedError in order to match spec.
- Reorders check for number of providers to after transient user
activation check in order to match spec.
- Makes allow-attribute.https.html test pass if the <iframe> does
not have user activation.

BUG=368070320

Change-Id: Iaa194da8d0a2a96d1fd40592dbe74e7bd7391bdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5883276
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1363719}
---
 digital-credentials/allow-attribute.https.html | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/digital-credentials/allow-attribute.https.html b/digital-credentials/allow-attribute.https.html
index a42a3b68f0e888..412236268086d8 100644
--- a/digital-credentials/allow-attribute.https.html
+++ b/digital-credentials/allow-attribute.https.html
@@ -116,11 +116,15 @@
                             );
                         });
                         const { name, message } = data;
-                        assert_equals(
-                            name,
-                            expectIsAllowed ? "TypeError" : "NotAllowedError",
-                            `${iframe.outerHTML} - ${message}`
-                        );
+                        if (expectIsAllowed) {
+                          assert_true(name == "TypeError" ||
+                                          (name == "NotAllowedError" && message.includes("transient activation")),
+                                      `${iframe.outerHTML} - ${message}`);
+                        } else {
+                          assert_equals(name, "NotAllowedError", `${iframe.outerHTML} - ${message}`);
+                          assert_false(message.includes("transient activation"),
+                                       `${iframe.outerHTML} - ${message}`);
+                        }
                         iframe.remove();
                     }, `Policy to use: ${details.policy}, is cross-origin: ${details.crossOrigin}, is allowed by policy: ${details.expectIsAllowed}`);
                 }