Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

Controller will not replace expired token #288

Open
bboreham opened this issue Aug 10, 2020 · 0 comments
Open

Controller will not replace expired token #288

bboreham opened this issue Aug 10, 2020 · 0 comments
Labels
bug Broken end user or developer functionality; not working as the developers intended it

Comments

@bboreham
Copy link
Contributor

From here:

if bootstrapTokenHasExpired(secret) {
newSecret, err := a.installNewBootstrapToken(ns)

to here:

s, err := a.clientSet.CoreV1().Secrets(ns).Create(context.TODO(), secret, metav1.CreateOptions{})
if err != nil {
return nil, gerrors.Errorf("failed to install new bootstrap token %s/%s", ns, secret.ObjectMeta.Name)

installNewBootstrapToken() will return an error if the Secret object already exists, so will not change it.

@bboreham bboreham added the bug Broken end user or developer functionality; not working as the developers intended it label Aug 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Broken end user or developer functionality; not working as the developers intended it
Projects
None yet
Development

No branches or pull requests

1 participant