Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

Need better explanation of "original master" #283

Open
bboreham opened this issue Jul 28, 2020 · 0 comments
Open

Need better explanation of "original master" #283

bboreham opened this issue Jul 28, 2020 · 0 comments
Labels
question Further information is requested

Comments

@bboreham
Copy link
Contributor

We use this label to check that one specific node is upgraded before others:

originalNeedsUpdate, err := a.checkIfOriginalMasterNotAtVersion(ctx, nodeStyleVersion)
if err != nil {
return err
}
contextLog.Infof("Original needs update: %t", originalNeedsUpdate)

But which node gets this label is arbitrary:

// There is no master node which is labeled with originalMasterLabel
// So we just pick nodes[0] of the list, then label it.
originalMasterNode := nodes[0]
if _, exist := originalMasterNode.Labels[originalMasterLabel]; !exist {
if err := a.setNodeLabel(ctx, originalMasterNode, originalMasterLabel, ""); err != nil {
return nil, err
}
}

It is quite likely we are singling out the first control-plane node in alphabetical order, but what relevance does that have to the rest of the system?

@bboreham bboreham added the question Further information is requested label Jul 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant