Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ring-serve project.clj pulls in ring 1.0.0 (needs to be updated to 1.1.0) #4

Open
jlr opened this issue May 10, 2012 · 1 comment
Open

Comments

@jlr
Copy link

jlr commented May 10, 2012

Hi, thanks for your great work on compojure and your other projects.

I'm just asking if you could please update the 'project.clj' of ring-serve to use [ring "1.1.0"].

Ring-serve pulls in ring 1.0.0 which creates a problem in my project because recent versions of hiccup changed a namespace name that ring 1.0.0 looks for. Ring 1.1.0 works fine with the newer hiccup.

Thanks!
p.s. I just stumbled on 'ring-server', should I be using that instead of 'ring-serve'?


(more details, in case you want them:
in ring 1.0.0, ring.middleware.stacktrace included hiccup.page-helpers, and hiccup now changed that ns to 'hiccup.page'. Ring 1.1.0 already updated to the new name. So since my project uses the latest version of hiccup, when I try to use ring.serve, it pulls: ring-serve -> ring 1.0.0 -> ring.middleware.stacktrace with the old ns name, and fails saying it can't find 'hiccup.page-helpers'.)

@weavejester
Copy link
Owner

Ring-serve pulls in ring 1.0.0 which creates a problem in my project because recent versions of hiccup changed a namespace name that ring 1.0.0 looks for. Ring 1.1.0 works fine with the newer hiccup.

Just explicitly include Ring 1.1.0 in your project dependencies. Leiningen will ensure you're using the latest versions.

p.s. I just stumbled on 'ring-server', should I be using that instead of 'ring-serve'?

Eventually I'll move everything from "ring-serve" to ring-server and deprecate the former in favour of the latter, but not all functionality has been moved over yet (such as the swank middleware).

  • James

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants