Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urllib downloader doesn't handle HTTP 302 redirects #1503

Closed
sunnyps opened this issue Sep 24, 2020 · 1 comment
Closed

Urllib downloader doesn't handle HTTP 302 redirects #1503

sunnyps opened this issue Sep 24, 2020 · 1 comment

Comments

@sunnyps
Copy link

sunnyps commented Sep 24, 2020

Some HTTP proxies will respond to requests with 302 redirects, and it seems Package Control's urllib downloader doesn't handle those.

By default urllib uses an HTTPRedirectHandler instance to handle redirects, but it's missing from the list of handlers in urllib_downloader.py setup_opener:

def setup_opener(self, url, timeout):

Package Control.sublime-settings.txt

package_control.log

@sunnyps
Copy link
Author

sunnyps commented Sep 24, 2020

Just noticed that #1502 is essentially the same issue, so feel free to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants