Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust version in Cargo.toml is out of date #1153

Closed
laurmaedje opened this issue Aug 27, 2024 · 4 comments · Fixed by #1195
Closed

Rust version in Cargo.toml is out of date #1153

laurmaedje opened this issue Aug 27, 2024 · 4 comments · Fixed by #1195

Comments

@laurmaedje
Copy link

When building with 1.77 as specified in Cargo.toml, you get this:

error[E0658]: associated type bounds are unstable
  --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wasmi-0.36.0/src/module/instantiate/mod.rs:54:40
   |
54 |         I: IntoIterator<Item = Extern, IntoIter: ExactSizeIterator>,
   |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #52662 <https://github.com/rust-lang/rust/issues/52662> for more information

Associated type bounds were stabilized in 1.79.

@Robbepop
Copy link
Member

Hi @laurmaedje thank you for reporting this. Ideally we should start to check the minimum rust version in our CI to prevent this from happening again.

@laurmaedje
Copy link
Author

Agreed! We do in Typst and that's how I actually found out about this.

@Robbepop
Copy link
Member

@laurmaedje I just implemented a small CI job to guard against this.

Have you had to deal with this? #1196
If so, how do you handle these (annoying) alerts?

@laurmaedje
Copy link
Author

I personally find dependabot annoying in general, so I've disabled it completely.

Maybe you can trick it by using something like this:

- uses: dtolnay/rust-toolchain@master
  with:
    toolchain: 1.79

Also confusing that it wants 1.90... since that Rust version isn't out for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants