New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement automatic checks #1

Closed

5 of 8 tasks

rudolfix opened this issue Aug 5, 2021 · 0 comments

Contributor

rudolfix commented Aug 5, 2021 •

edited by konstantinullrich

Loading

Please add following checks

check if contracts compile & check if contracts deploy (to the ganache inprocess network to make it easy)
add linter (find which one is currently state of the art, I was using solium) and run linter check
add check with tests
optionally: add check with code coverage and connect it to one of code coverage reporting services ie. codecov or coverall, check update truffle file Neufund/platform-contracts#369 for reference

Make checks running

on every push to a branch
on merge to master
disallow merging if checks do not pass
disallow pushing to master

The text was updated successfully, but these errors were encountered:

rudolfix assigned konstantinullrich

konstantinullrich closed this as completed

rudolfix mentioned this issue

add badges and separate workflows #13

Closed

gmussi unassigned konstantinullrich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment