Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: store v3 - passing a cursor that doesn't correspond to any message in the store will return all messages #1110

Open
fbarbu15 opened this issue May 23, 2024 · 0 comments

Comments

@fbarbu15
Copy link

Describe the bug
Issue reproduces if we pass a valid cursor, a invalid base 64 string or even a normal string. All messages are returned in all 3 cases. I would expect no message to be returned.
The issue is the same as nwaku issue: waku-org/nwaku#2716

To Reproduce

  1. Have 4 messages in the store
  2. Send a store v3 request with a plain string as a cursor ex:
    curl -v -X GET "http://127.0.0.1:7945/store/v3/messages?pubsubTopic=%2Fwaku%2F2%2Frs%2F0%2F0&contentTopics=%2Fmyapp%2F1%2Flatest%2Fproto&cursor=test&pageSize=100&ascending=true" -H "Content-Type: application/json"

Actual behavior

All messages in the store are returned

Expected behavior

Either empty messages list or an error saying that cursor doesn't match any message in the store

go-waku version/commit hash

harbor.status.im/wakuorg/go-waku:latest

Additional context
Logs

publishing_node.log
store_node.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant