Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking a historical artifact... #242

Closed
iherman opened this issue Feb 4, 2024 · 3 comments
Closed

Checking a historical artifact... #242

iherman opened this issue Feb 4, 2024 · 3 comments
Assignees
Labels
CR1 This item was processed during the first Candidate Recommendation phase. pr exists A pull request exists to address this issue.

Comments

@iherman
Copy link
Member

iherman commented Feb 4, 2024

We already have, currently, a discrepancy in the security vocabulary. The term defined in the vocabulary is expiration but it is referred to in the security vocabulary context file as expires. The vocabulary contains the following comment:

Historically, this property has often been expressed using expires as a shortened term in JSON-LD. Since this shortened term and its mapping to this property are in significant use in the ecosystem, the inconsistency between the short term name (expires) and the property identifier (...#expiration) is expected and should not trigger an error.

I realized today that there are four more similar discrepancies between the context file and the vocabulary namely

short name for JSONLD in the context vocabulary term used in the context current vocabulary term
authentication authenticationMethod authentication
capabilityInvocation capabilityInvocationMethod capabilityInvocation
capabilityDelegation capabilityDelegationMethod capabilityDelegation
keyAgreement keyAgreementMethod keyAgreement

I presume that the vocabulary file should be changed, and it should refer to ...Method with a similar comment. However, I would prefer to get a reinforcement from the WG before doing a change.

@dlongley @msporny

@iherman iherman added the CR1 This item was processed during the first Candidate Recommendation phase. label Feb 4, 2024
@iherman iherman self-assigned this Feb 4, 2024
@dlongley
Copy link
Contributor

dlongley commented Feb 4, 2024

Yes, the vocabulary needs to be updated to reflect the vocab terms used in the context as stated above in the table.

@iherman
Copy link
Member Author

iherman commented Feb 11, 2024

This issue is being taken care of in #243; it can be closed if and when the PR is merged.

@iherman iherman added the pr exists A pull request exists to address this issue. label Feb 11, 2024
@msporny
Copy link
Member

msporny commented Feb 24, 2024

PR #243 has been merged, closing.

@msporny msporny closed this as completed Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR1 This item was processed during the first Candidate Recommendation phase. pr exists A pull request exists to address this issue.
Projects
None yet
Development

No branches or pull requests

3 participants