Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explanation about why proof graphs are used #190

Closed
msporny opened this issue Sep 14, 2023 · 4 comments
Closed

Add explanation about why proof graphs are used #190

msporny opened this issue Sep 14, 2023 · 4 comments
Assignees
@msporny
Labels
CR1 This item was processed during the first Candidate Recommendation phase. editorial This issue or PR constitutes an editorial change. pr exists A pull request exists to address this issue.

Comments

@msporny
Copy link
Member

msporny commented Sep 14, 2023

The VC Data Model added an explanation related to VC graphs in PR w3c/vc-data-model#1280. The Data Integrity specification should do the same.
@msporny msporny added the CR1 This item was processed during the first Candidate Recommendation phase. label Sep 14, 2023
@msporny
Copy link
Member Author

msporny commented Dec 27, 2023

This request is also related to a request by @iherman in this comment: w3c/vc-data-model#1403 (review)

@msporny msporny mentioned this issue Dec 27, 2023
Merged
@iherman
Copy link
Member

iherman commented Jan 13, 2024

This is also related to the discussion in w3c/vc-data-model#1397 (review): the fact that the proof property's value is a named graph, i.e., that the property refers to a container property in JSON-LD parlance, must be clearly specified in the DI specification (it was, so far, part of the VCDM spec, but has been removed as part of w3c/vc-data-model#1397).

@iherman iherman mentioned this issue Jan 13, 2024
Closed
@msporny msporny added the editorial This issue or PR constitutes an editorial change. label Feb 25, 2024
@msporny msporny self-assigned this Jun 20, 2024
@msporny msporny mentioned this issue Jun 20, 2024
Merged
@msporny
Copy link
Member Author

msporny commented Jun 20, 2024

PR #270 has been raised to address this issue. This issue will be closed once PR #270 has been merged.

@msporny msporny added the pr exists A pull request exists to address this issue. label Jun 20, 2024
@msporny
Copy link
Member Author

msporny commented Jun 29, 2024

PR #270 has been merged, closing.

@msporny msporny closed this as completed Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msporny msporny

Labels
CR1 This item was processed during the first Candidate Recommendation phase. editorial This issue or PR constitutes an editorial change. pr exists A pull request exists to address this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@msporny @iherman