Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computation steps, section 2C could be more clear #244

Open
tranjocelyn opened this issue Jul 23, 2024 · 8 comments · May be fixed by w3c/aria#2299
Open

Computation steps, section 2C could be more clear #244

tranjocelyn opened this issue Jul 23, 2024 · 8 comments · May be fixed by w3c/aria#2299

Comments

@tranjocelyn
Copy link

@aleventhal and I were reading the computation steps, section 2C:

Otherwise, if the current node is a control embedded within the label (e.g. any element directly referenced by aria-labelledby) for another widget, where the user can adjust the embedded control's value, then return the embedded control as part of the text alternative in the following manner:

We're not 100% sure what this means and we thought others might also find it confusing. Would it be possible to revise this step for improved clarity? Including additional examples could be helpful as well. Thanks!

@accdc
Copy link
Contributor

accdc commented Jul 23, 2024

I agree, this should say the following instead.

Otherwise, if the current node is a control embedded within the label (e.g. any element directly referenced by aria-labelledby) for another widget, where the user can adjust the embedded control's value, then return the embedded control's value as part of the text alternative in the following manner:

It should directly reference the value of the embedded control. Does this make more sense?

@aleventhal
Copy link
Contributor

aleventhal commented Jul 24, 2024 via email

@scottaohara
Copy link
Member

scottaohara commented Jul 24, 2024

this is how i'm interpreting what that text says

<div id=f>
  color
  <input type=text value="red" aria-labelledby=f> <!-- 1 -->
</div >
<input aria-labelledby=f> <!-- 2 (another widget) -->

expected names:
input 1: color
input 2: color red

in chromium, the above returns "color red" for input 1. and that doesn't seem like the right outcome, and it also differs from how the following, which does match my name expectations, above:

<label id=f>
	color
	<input type=text value=red>
</label>

<input type=text aria-labelledby=f>

expected/actual names:
input 1: color
input 2: color red

@aleventhal
Copy link
Contributor

How about:

If the current node is a user-adjustable control embedded within the label, and the control is not recursively referencing itself, then return the embedded control's value as part of the text alternative in the following manner:

@aleventhal
Copy link
Contributor

Or

If the current node is a user-adjustable control embedded within the label, and the control is not the element being named or described, then return the embedded control's value as part of the text alternative in the following manner:

@accdc
Copy link
Contributor

accdc commented Jul 24, 2024

That last one sounds good to me personally.

@aleventhal
Copy link
Contributor

@accdc or @tranjocelyn could one of you update the spec text?

MelSumner added a commit to w3c/aria that referenced this issue Jul 31, 2024
If merged, this PR updates step 2C to be the agreed upon text per this issue: w3c/accname#244
@MelSumner
Copy link
Contributor

@aleventhal tagged you in the PR so you can let me know if I have accurately captured your requested text update.

@jnurthen jnurthen removed the Agenda label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants