Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: why use terms_of_service_url instead of tos_uri? #591

Closed
ThisIsMissEm opened this issue May 19, 2024 · 2 comments
Closed

Question: why use terms_of_service_url instead of tos_uri? #591

ThisIsMissEm opened this issue May 19, 2024 · 2 comments

Comments

@ThisIsMissEm
Copy link

In the Client Metadata response, the properties are named privacy_policy_url" and "terms_of_service_url", in OAuth 2 Fynamic Client Registration, these are "policy_uri" and "tos_uri". Since FedCM is based off OAuth / OIDC, why does the language here deviate?

Also, when requesting Client Metadata, can the browser send the Accept-Language header to allow the IdP to return URIs to documents in The user's language?

@ThisIsMissEm ThisIsMissEm changed the title Question: why use ter Question: why use terms_of_service_url instead of tos_uri? May 20, 2024
@samuelgoto
Copy link
Collaborator

Since FedCM is based off OAuth / OIDC, why does the language here deviate?

Because it is not: FedCM has to support SAML (or anything that's invented in the future) as well.

Also, when requesting Client Metadata, can the browser send the Accept-Language header to allow the IdP to return URIs to documents in The user's language?

Ah yes, great idea!

I kicked off #592 to track that suggestion independently.

I'm closing this since I think I answered your question (feel free to reopen if you'd like more clarification on the reason why we deliberately deviated from OIDC/OAuth) and we can carry on on the other issue for the language suggestion.

@ThisIsMissEm
Copy link
Author

Ah, okay, yeah, that makes sense — I'd just seem a lot of OIDC / OAuth terminology whilst reading the spec, so wasn't sure why we'd deviate; tbh, I like the long form better anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants