RFC - Removal of the Sidebar and Topbar components from admin-ui #571
Replies: 6 comments 2 replies
-
In the past we had some motivation to move these components for the admin-ui, for example:
Now I see that we have a more mature lib and I agree to move both components to the admin-shell. IMO they are very specific, and we only had the intention of developing it to be used by the admin until now. One thing about being used only on the admin-shell, it looks like we have another project using it as well. We should double-check and warn them if necessary and we decide to remove it |
Beta Was this translation helpful? Give feedback.
-
The migration does make sense to me. The sidebar and topbar exist as any other Admin module that is constructed based on the Admin UI and can evolve/change according to user or business needs. |
Beta Was this translation helpful? Give feedback.
-
Another con is that we will not be able to reuse it somewhere else. Keep in mind that generally design systems keep these global components on their codebase since they're an essential part of the product. For reference:
|
Beta Was this translation helpful? Give feedback.
-
This is being addressed by: |
Beta Was this translation helpful? Give feedback.
-
@matheusps @marcelovicentegc Can we close this? |
Beta Was this translation helpful? Give feedback.
-
RFC - Removal of the Sidebar and Topbar components from admin-ui
Problem
Currently, we have two components that are somehow hidden on the library and are only used on the admin-shell: the Sidebar and the Topbar components.
Whenever changes are required for these components, these demands come from adaptations to the admin-shell. They were thought and implemented for this specific application, and not for general use such as the Button, DataGrid and Page components for instance.
There is little to no use for them to live within this package, and the price we pay for having them live within admin-ui is high, since we can't directly make changes to them on the only application that uses them: the admin-shell.
If a change on the Sidebar or Topbar of the admin-shell is required, this is what we do:
When it could simply be:
Proposal
Remove the Sidebar and Topbar components from admin-ui, and bring them to the admin-shell. In case we decide that we want to expose these components to the world, we should then properly document and reference it on admin-ui documentation.
Pros
Cons
Unresolved questions
Does it make sense to incorporate the Sidebar and Topbar components into the admin-ui library?
Beta Was this translation helpful? Give feedback.
All reactions