Updating Poedit repeats download when I press Space

[rillig]

In Poedit 2.3.1, click File > Check for updates…:

Press Enter. The update file is downloaded:

Press Alt+Tab twice. The blue focus border around the button disappears. This is unexpected. See vslavik/poedit#650.

Press Space. The window closes. This is unexpected as well.

Hmmm, some minutes ago, when I pressed Space, the download repeated, which was unexpected. Now the window closes, which is also unexpected.

Ok, next try. Without getting distracted or doing any key press in-between:

1. Click on File > Check for updates…
2. Tab Tab Tab Tab Enter
3. Wait until the download has finished
4. Space

These are very subtle differences. In this case, it really makes a difference whether I press a key or click using the mouse. I hope you can reproduce some of these edge cases.

Windows 10.0.18362.959, Poedit 2.3.1.

I won't install the update right now, just in case you want me to reproduce the above behavior once more. :)

[vslavik]

I won't install the update right now, just in case you want me to reproduce the above behavior once more. :)

Sorry, I missed this bit. Feel free, the updater is isolated from the hosting app and it shouldn't be an issue to reproduce.

[hmmwhatsthisdo]

I'm also hitting this in Wireshark (which uses WinSparkle) - see this issue.

There's two failure modes that I identified:

• Pressing space on the "New version is available" dialog closes the dialog instead of progressing through the updater.
• Pressing space on the "Ready to install" dialog re-downloads the update (as if I had re-clicked the since-hidden "Install update" button from the previous dialog).

This post from the wxWidgets forum suggests this might be two related issues:

• Control focus isn't being properly set on the two dialogs after they're opened.
• The buttons from the first dialog are being hidden (but not disabled) after the user clicks "Install update", meaning keyboard focus is still retained on the now-hidden button.

[vslavik]

@hmmwhatsthisdo That's plausible, thanks for the good analysis!