Fix spawn sync (#130)

* added shell=true parameter to spawnSync calls * fixed watched file events from appending log entries when not enabled, fixes vshaxe/vshaxe#636
vshaxe · Aug 16, 2024 · 9c3114d · 9c3114d
1 parent 90dc446
commit 9c3114d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/src/haxeLanguageServer/features/haxe/DiagnosticsFeature.hx b/src/haxeLanguageServer/features/haxe/DiagnosticsFeature.hx
@@ -51,7 +51,7 @@ class DiagnosticsFeature {
 		}
 		timerName = useJsonRpc ? DisplayMethods.Diagnostics : "@diagnostics";
 
-		ChildProcess.exec(context.config.haxelib.executable + " config", (error, stdout, stderr) -> haxelibPath = new FsPath(stdout.trim()));
+		ChildProcess.exec(context.config.haxelib.executable + " config", {shell: true}, (error, stdout, stderr) -> haxelibPath = new FsPath(stdout.trim()));
 
 		context.languageServerProtocol.onNotification(LanguageServerMethods.RunGlobalDiagnostics, onRunGlobalDiagnostics);
 	}

diff --git a/src/haxeLanguageServer/server/HaxeServer.hx b/src/haxeLanguageServer/server/HaxeServer.hx
@@ -116,7 +116,7 @@ class HaxeServer {
 		mergeEnvs(js.Node.process.env, env);
 		mergeEnvs(config.env, env);
 
-		final spawnOptions = {env: env, cwd: context.workspacePath.toString()};
+		final spawnOptions = {env: env, cwd: context.workspacePath.toString(), shell: true};
 
 		if (!checkHaxeVersion(config.path, spawnOptions)) {
 			return;

diff --git a/src/haxeLanguageServer/server/ServerRecording.hx b/src/haxeLanguageServer/server/ServerRecording.hx
@@ -2,14 +2,14 @@ package haxeLanguageServer.server;
 
 import haxe.Json;
 import haxe.io.Path;
+import haxeLanguageServer.Configuration.ServerRecordingConfig;
+import haxeLanguageServer.helper.FsHelper;
+import haxeLanguageServer.server.ServerRecordingTools.getVcsState;
 import jsonrpc.CancellationToken;
 import jsonrpc.ResponseError;
+import sys.FileSystem;
 import sys.io.File;
 import sys.io.FileOutput;
-import sys.FileSystem;
-import haxeLanguageServer.Configuration.ServerRecordingConfig;
-import haxeLanguageServer.helper.FsHelper;
-import haxeLanguageServer.server.ServerRecordingTools.getVcsState;
 
 using StringTools;
 using haxeLanguageServer.helper.StringHelper;
@@ -170,6 +170,9 @@ class ServerRecording {
 	}
 
 	public function onFileEvent(event:FileEvent):Void {
+		if (!enabled)
+			return;
+
 		final kind = switch (event.type) {
 			case Changed: "fileChanged";
 			case Created: "fileCreated";