Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: concurrent map read and map write #28

Open
datastream opened this issue Aug 15, 2019 · 0 comments
Open

Fix: concurrent map read and map write #28

datastream opened this issue Aug 15, 2019 · 0 comments

Comments

@datastream
Copy link

c.requestList should be protected by mutex lock.

if requestToAbandon, ok := c.requestList[messageID]; ok {

`diff --git a/client.go b/client.go
index a174d36..665743d 100644
--- a/client.go
+++ b/client.go
@@ -39,9 +39,12 @@ func (c *client) SetConn(conn net.Conn) {
}

func (c *client) GetMessageByID(messageID int) (*Message, bool) {

  •   c.mutex.Lock()
      if requestToAbandon, ok := c.requestList[messageID]; ok {
    
  •           c.mutex.Unlock()
              return requestToAbandon, true
      }
    
  •   c.mutex.Unlock()
      return nil, false
    

}`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant