Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translations broken #1509

Open
DanielMcInnes opened this issue Sep 26, 2024 · 6 comments
Open

Translations broken #1509

DanielMcInnes opened this issue Sep 26, 2024 · 6 comments
Assignees
@DanielMcInnes
Labels
high_prio High priority
Milestone
Version 1.0.0

Comments

@DanielMcInnes
Copy link
Contributor

see https://community.victronenergy.com/t/v3-50-24-gui-v2-some-chinese-strings-not-translated/4917
@DanielMcInnes DanielMcInnes added the blocked Waiting for venus-platform or other support label Sep 26, 2024
@DanielMcInnes DanielMcInnes added this to the Version 1.0.0 milestone Sep 26, 2024
@mpvader mpvader added the high_prio High priority label Sep 26, 2024
@DanielMcInnes DanielMcInnes removed the blocked Waiting for venus-platform or other support label Sep 26, 2024
@jhofstee
Copy link
Contributor

related #1256

@dirkjanfaber
Copy link
Contributor

In the translation file i18n/venus-gui-v2_zh_CN.ts , I do see the translation being available:

    <message id="common_words_battery_temperature">
      <location filename="../../components/CommonWords.qml" line="86"/>
      <source>Battery temperature</source>
      <translation>电池温度</translation>
    </message>

@DanielMcInnes
Copy link
Contributor Author

In the translation file i18n/venus-gui-v2_zh_CN.ts , I do see the translation being available:

    <message id="common_words_battery_temperature">
      <location filename="../../components/CommonWords.qml" line="86"/>
      <source>Battery temperature</source>
      <translation>电池温度</translation>
    </message>

Yes, I think something else is going wrong here

@DanielMcInnes DanielMcInnes self-assigned this Sep 26, 2024
@DanielMcInnes
Copy link
Contributor Author

I remember seeing something in the console logs along the lines of: "Error: ZH_cn country code not recognized", which could have something to do with it

@blammit
Copy link
Contributor

blammit commented Sep 27, 2024 •
edited
Loading

This is the same issue as #1234? I wonder if we should rework the translations for 1.1.0 as per #1256 .

@DanielMcInnes
Copy link
Contributor Author

It looks like the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielMcInnes DanielMcInnes

Labels
high_prio High priority
Projects
None yet
Milestone
Version 1.0.0
Development

No branches or pull requests
5 participants
@blammit @jhofstee @dirkjanfaber @mpvader @DanielMcInnes