fix(xo-server/xo-web/mirrorBackup): correct new schedule property on …

…edited mirror backup job (#8001) Introduced by ee0adae
vatesfr · Sep 26, 2024 · 943ad78 · 943ad78
1 parent 6b21f08
commit 943ad78
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md
@@ -45,4 +45,6 @@
 - xen-api minor
 - xo-cli minor
 - xo-server minor
+- xo-web patch
+
 <!--packages-end-->
diff --git a/packages/xo-server/src/api/mirror-backup.mjs b/packages/xo-server/src/api/mirror-backup.mjs
@@ -113,10 +113,6 @@ editJob.params = {
   remotes: {
     type: 'object',
   },
-  schedules: {
-    type: 'object',
-    optional: true,
-  },
   filter: MIRROR_BACKUP_FILTER,
   settings: SCHEMA_SETTINGS,
 }

diff --git a/packages/xo-web/src/xo-app/backup/new/mirror/index.js b/packages/xo-web/src/xo-app/backup/new/mirror/index.js
@@ -189,7 +189,6 @@ const NewMirrorBackup = decorate([
         }
 
         const settings = { ...state.settings }
-        const schedules = { ...state.schedules }
         await Promise.all([
           ...map(props.schedules, ({ id }) => {
             const schedule = state.schedules[id]
@@ -214,16 +213,16 @@ const NewMirrorBackup = decorate([
                 enabled: schedule.enabled,
               })
               settings[newSchedule.id] = settings[schedule.id]
-              schedules[newSchedule.id] = newSchedule
               delete settings[schedule.id]
-              delete schedules[schedule.id]
             }
           }),
         ])
 
+        const { schedules, ...jobProps } = normalize({ ...state, settings, isIncremental: state.isIncremental })
+
         await editMirrorBackupJob({
           id: props.job.id,
-          ...normalize({ ...state, settings, schedules, isIncremental: state.isIncremental }),
+          ...jobProps,
         })
       },
       resetMirrorBackup: () => (_, props) => getInitialState(props),