Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please do not use base64 #4

Closed
DanielRuf opened this issue Oct 18, 2013 · 9 comments
Closed

please do not use base64 #4

DanielRuf opened this issue Oct 18, 2013 · 9 comments
Labels

Comments

@DanielRuf
Copy link

In my opinion it makes no sense to create a huge JSON file, a mess of base64 encoded image files.

The approach from JSMovie is much faster and better
See also #3

The images can be also loaded parallely

@roman01la
Copy link

+1 to not to use base64, it's slow on mobile and drains battery because of heavy encoding process.
Please, check this research.

@vagnervjs
Copy link
Owner

Thanks for sharing this research @roman01la. It's realy true, and I agree. I'll implement this changes on Frame Player

@vagnervjs
Copy link
Owner

Hey @DanielRuf and @roman01la , I made the change of JSON/base64-URI to images files URL's. Can you guys see it and and leave your opinions?

The main code is: https://github.com/vagnervjs/frame-player/blob/img-tag/src/js/frameplayer.js
There is a branch just for this change: https://github.com/vagnervjs/frame-player/tree/img-tag

And the on-line player using this version is at: http://vagnersantana.com/frame/

@roman01la
Copy link

Looks good for me. Just wonder if still going to use CSS Filters? It's not just much heavier stuff in terms of battery life but also it makes a huge impact on the rendering performance on the web page. Should we move this to another issue?

@DanielRuf
Copy link
Author

works much better, but this makes no sense at the moment:
https://github.com/vagnervjs/frame-player/blob/img-tag/src/js/frameplayer.js#L259

we should move this to the configuration in the js file and use the parameter set by the function

@roman01la did you take a look at the demo? they are much better than canvas filters in case of performance, or what do you think?

http://caniuse.com/#search=canvas

https://github.com/meltingice/CamanJS/
https://github.com/jseidelin/pixastic
https://github.com/mezzoblue/PaintbrushJS

@vagnervjs
Copy link
Owner

Thanks for the reply @roman01la

I thought in point of css filters too, just create this issue #6 about this

@vagnervjs
Copy link
Owner

Yes @DanielRuf, this constant no make senses, It's just for test at this moment, I'll create the new parameter

@DanielRuf
Copy link
Author

@vagnervjs ok, I already thought this

@vagnervjs
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants