-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
please do not use base64 #4
Comments
+1 to not to use base64, it's slow on mobile and drains battery because of heavy encoding process. |
Thanks for sharing this research @roman01la. It's realy true, and I agree. I'll implement this changes on Frame Player |
Hey @DanielRuf and @roman01la , I made the change of JSON/base64-URI to images files URL's. Can you guys see it and and leave your opinions? The main code is: https://github.com/vagnervjs/frame-player/blob/img-tag/src/js/frameplayer.js And the on-line player using this version is at: http://vagnersantana.com/frame/ |
Looks good for me. Just wonder if still going to use CSS Filters? It's not just much heavier stuff in terms of battery life but also it makes a huge impact on the rendering performance on the web page. Should we move this to another issue? |
works much better, but this makes no sense at the moment: we should move this to the configuration in the js file and use the parameter set by the function @roman01la did you take a look at the demo? they are much better than canvas filters in case of performance, or what do you think? http://caniuse.com/#search=canvas https://github.com/meltingice/CamanJS/ |
Thanks for the reply @roman01la I thought in point of css filters too, just create this issue #6 about this |
Yes @DanielRuf, this constant no make senses, It's just for test at this moment, I'll create the new parameter |
@vagnervjs ok, I already thought this |
Add the new parameter frames: https://github.com/vagnervjs/frame-player/blob/img-tag/src/js/frameplayer.js#L261 |
In my opinion it makes no sense to create a huge JSON file, a mess of base64 encoded image files.
The approach from JSMovie is much faster and better
See also #3
The images can be also loaded parallely
The text was updated successfully, but these errors were encountered: