Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workalendar features into holidays package #1930

Open
ncooder opened this issue Aug 17, 2024 · 4 comments
Open

Workalendar features into holidays package #1930

ncooder opened this issue Aug 17, 2024 · 4 comments

Comments

@ncooder
Copy link

ncooder commented Aug 17, 2024

As workalendar package is no longer actively maintained, I suggest to incorporate its functionality for calculating working days into this package. This integration would provide users with a reliable and up-to-date solution for working day calculations.

@arkid15r
Copy link
Collaborator

As workalendar package is no longer actively maintained, I suggest to incorporate its functionality for calculating working days into this package. This integration would provide users with a reliable and up-to-date solution for working day calculations.

Any examples of the suggested functionality?

It'd be really helpful if you used the issue template. Thank you!

@ncooder
Copy link
Author

ncooder commented Aug 20, 2024

As workalendar package is no longer actively maintained, I suggest to incorporate its functionality for calculating working days into this package. This integration would provide users with a reliable and up-to-date solution for working day calculations.

Any examples of the suggested functionality?

It'd be really helpful if you used the issue template. Thank you!

Especially calculating working days count. I believe that many of those features that are implemented in the workalendar can be transferred to the holidays package, such as:

  • weekend days for ISO country codes,
  • validation of ISO country codes with exact dates of future holidays (as a base).
    The point is that several issues in this package are already solved and can be easily used in the holidays package.

@PPsyrius
Copy link
Collaborator

PPsyrius commented Sep 11, 2024

So, to recap, these functions - right? @ncooder

  • .is_working_day(date) - check if neither weekend or holidays.
  • .add_working_days(date, days) - get the next nth day that's neither weekend or holidays.
  • .get_working_days_delta(date1, date2) - get the amount of workdays between the two dates that's neither weekend or holidays.
  • .export_to_ical(period) - exports holidays to iCal file format.

I'm pretty sure other syntactic sugars listed in advance features are already supported by python-holidays natively.

@ncooder
Copy link
Author

ncooder commented Sep 13, 2024

@PPsyrius Yes, exactly. Thank you for this list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants