Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passing the varience to the function compute_log_likelihood() in file eval.py #5

Open
MoHassoubah opened this issue Sep 14, 2021 · 2 comments

Comments

@MoHassoubah
Copy link

Hello ,

thank you very much for your effort,

I have a question, in file eval.py
the function compute_preds(), returns the variance of the model "model_variance",
then the variable "outputs_variance" is passed to the function compute_log_likelihood() as "sigma"
yet in the function compute_log_likelihood(), the function torch.distributions.normal.Normal() takes "loc" which is the mean of the distribution and "scale" which is the standard deviation
yet you are passing the variance not the std to "scale"??

@MoHassoubah
Copy link
Author

@mattiasegu

@mattiasegu
Copy link
Contributor

Hi @MoHassoubah, you are right, it should be the std! I fixed this already in the version of the repo on my github: https://github.com/mattiasegu/uncertainty_estimation_deep_learning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants