Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plumb through the new Signal and H5 models #83

Open
thequicksort opened this issue Feb 4, 2021 · 1 comment
Open

Plumb through the new Signal and H5 models #83

thequicksort opened this issue Feb 4, 2021 · 1 comment
Assignees
@thequicksort
Milestone
1.0.0

Comments

@thequicksort
Copy link
Contributor

Data abstraction is good! Let's now use these abstractions in their proper places.

Signals have been abstracted to classes. H5 methods are moved from raw_signal_utils to fast5adapter (this isn't a great name for the model, let me know in the comments if you have a better one)
@thequicksort thequicksort added this to the 1.0.0 milestone Feb 4, 2021
@thequicksort thequicksort self-assigned this Feb 4, 2021
thequicksort pushed a commit that referenced this issue Feb 4, 2021
[#83] Introduce abstractions for signals and fast5 files
e8a2fb5
@kdoroschak
Copy link
Member

perhaps fast5io? As long as we actually move the "o" part of "io" to this file too.

kdoroschak added a commit that referenced this issue Feb 15, 2021
@thequicksort @kdoroschak
[#83] Introduce abstractions for signals and fast5 files (#84)
6726284 
* [#83] Introduce abstractions for signals and fast5 files

* Removed class method from FractionalizedSignal

* Architecting signal and fast5 data organization

Co-authored-by: Jessica Dunstan <[email protected]>
Co-authored-by: Katie Doroschak <[email protected]>
thequicksort added a commit that referenced this issue Feb 15, 2021
@thequicksort @kdoroschak
[#83] Introduce abstractions for signals and fast5 files (#84)
3aa47ac 
* [#83] Introduce abstractions for signals and fast5 files

* Removed class method from FractionalizedSignal

* Architecting signal and fast5 data organization

Co-authored-by: Jessica Dunstan <[email protected]>
Co-authored-by: Katie Doroschak <[email protected]>
thequicksort added a commit that referenced this issue Mar 3, 2021
@thequicksort @kdoroschak
[#83] Introduce abstractions for signals and fast5 files (#84)
2fde341 
* [#83] Introduce abstractions for signals and fast5 files

* Removed class method from FractionalizedSignal

* Architecting signal and fast5 data organization

Co-authored-by: Jessica Dunstan <[email protected]>
Co-authored-by: Katie Doroschak <[email protected]>
thequicksort added a commit that referenced this issue Mar 12, 2021
@thequicksort @kdoroschak
Segmentation and Cachix
da7d02d 
* Added cachix bootstrap. Fixed bootstrap for Linux.

* Pytest ini updated.

* Change HDF to Fast5.

* added Nix.test for our test work

* [#83] Introduce abstractions for signals and fast5 files (#84)

* [#83] Introduce abstractions for signals and fast5 files

* Removed class method from FractionalizedSignal

* Architecting signal and fast5 data organization

Co-authored-by: Jessica Dunstan <[email protected]>
Co-authored-by: Katie Doroschak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thequicksort thequicksort

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@kdoroschak @thequicksort