diff --git a/libraries/ms-helper/rules.mk b/libraries/ms-helper/rules.mk index 37796dd8e..cd1387b19 100644 --- a/libraries/ms-helper/rules.mk +++ b/libraries/ms-helper/rules.mk @@ -12,7 +12,7 @@ $(T)_DEPS += mu-gen mu-store endif ifeq (x86,$(PLATFORM)) -$(T)_EXCLUDE_TESTS := mcp2515 adc_periodic_reader +$(T)_EXCLUDE_TESTS := adc_periodic_reader endif $(T)_test_thermistor_MOCKS := adc_read_converted adc_get_channel adc_set_channel diff --git a/libraries/ms-helper/src/mcp2515.c b/libraries/ms-helper/src/mcp2515.c index cdcbae92d..c7bafe227 100644 --- a/libraries/ms-helper/src/mcp2515.c +++ b/libraries/ms-helper/src/mcp2515.c @@ -273,7 +273,7 @@ StatusCode mcp2515_init(Mcp2515Storage *storage, const Mcp2515Settings *settings MCP2515_CANCTRL_OPMODE_CONFIG | MCP2515_CANCTRL_CLKOUT_CLKPRE_4); // set RXB0 ctrl BUKT bit on to enable rollover to rx1 - prv_bit_modify(storage, MCP2515_CTRL_REG_RXB0CTRL, 1 << 3, 1 << 3); + prv_bit_modify(storage, MCP2515_CTRL_REG_RXB0CTRL, 1 << 3, 1 << 3); // Replace the magic numbers prv_configure_filters(storage, settings->filters); @@ -301,6 +301,7 @@ StatusCode mcp2515_init(Mcp2515Storage *storage, const Mcp2515Settings *settings prv_bit_modify(storage, MCP2515_CTRL_REG_CANCTRL, MCP2515_CANCTRL_OPMODE_MASK, opmode); // Active-low interrupt pin const GpioSettings gpio_settings = { + // potentially set up the rest of the fields .direction = GPIO_DIR_IN, };