Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make files advanced #3

Open
4 of 16 tasks
vivaan2006 opened this issue Jul 25, 2023 · 5 comments
Open
4 of 16 tasks

Make files advanced #3

vivaan2006 opened this issue Jul 25, 2023 · 5 comments

Comments

@vivaan2006
Copy link
Contributor

vivaan2006 commented Jul 25, 2023

1 file directories

  • call_method
  • call_method_slots
  • call_simple
  • chaos
  • float
  • meteor
  • pidigits
  • pythonflow
  • spectralnorm

2, 3, 4 file directories...

  • Espionage
  • futen (4)
  • go (3)
  • http2
  • take5
  • slowsha
  • samplefsm
@bennn
Copy link
Member

bennn commented Jul 27, 2023

Use deltablue, fannkuch, nbody, and richards as inspiration:

  • replace simple dicts with CheckedDict[K, V]
  • ditto for lists and CheckedList[T]
  • replace int with int64, same for floats
  • replace lists of ints with arrays (see nqueens)
  • annotate classes with @final, annotate tiny functions with @inline

@vivaan2006
Copy link
Contributor Author

the 1-file benchmarks are done, errors in a few, have to experiment with types later. Moving onto 2 files now. Most interesting error was: KeyError: (<ast.Call object at 0x7f58c66bf220>, <class 'compiler.static.types.ClassCallInfo'>) Not sure if this relates to the compiler, but this was odd...

@bennn
Copy link
Member

bennn commented Aug 26, 2023

Most interesting error was: KeyError: (<ast.Call object at 0x7f58c66bf220>, <class 'compiler.static.types.ClassCallInfo'>) Not sure if this relates to the compiler, but this was odd...

What's the code that gave that error?

The advanced call_* benchmarks look great.

float advanced is the same as float shallow. Is there a float64 type to use? Check the cinder tests under Lib/test/test_compiler/test_static/ for examples with primitive types.

@vivaan2006
Copy link
Contributor Author

Hello, I looked into the files in test_static, but I couldn't find any special float types. The main primitive types throughout the code were: int32, int64, int8 but no float 64

@bennn
Copy link
Member

bennn commented Aug 30, 2023

I'm surprised about float64. Does the paper say anything about it?? We can figure this out on the next call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants