From cf338dd445e0de20ffd271d0f63cdc0e09963f3d Mon Sep 17 00:00:00 2001 From: Sushil Rajeeva Bhandary Date: Sat, 24 Aug 2024 02:51:39 -0400 Subject: [PATCH 1/3] feat: Add client-side feature flag for Follow+Notes functionality Introduced a new client-side feature flag named followNotesEnabled as part of the implementation for the "Follow + Note" feature - Implemented followNotesEnabled feature flag in index.js. - Registered the flag with default true in deploy-config.js. - Added flag to staging.tfvars and prod.tfvars with false default. - Reformatted lines 16-17 in deploy-config.js for ESLint compliance. --- packages/client/public/deploy-config.js | 8 ++++++-- packages/client/src/helpers/featureFlags/index.js | 4 ++++ terraform/prod.tfvars | 1 + terraform/staging.tfvars | 1 + 4 files changed, 12 insertions(+), 2 deletions(-) diff --git a/packages/client/public/deploy-config.js b/packages/client/public/deploy-config.js index 83ff64e09..1dcdafedf 100644 --- a/packages/client/public/deploy-config.js +++ b/packages/client/public/deploy-config.js @@ -13,8 +13,11 @@ window.APP_CONFIG.overrideFeatureFlag = (flagName, overrideValue) => { } overrides[flagName] = overrideValue; window.sessionStorage.setItem(storageKey, JSON.stringify(overrides)); - console.log('New feature flag overrides in page session:', - window.sessionStorage.getItem(storageKey)); + // Reformatted according to common ESLint rules + /* eslint-disable no-console */ + // console.log('New feature flag overrides in page session:', window.sessionStorage.getItem(storageKey)); + console.log(`New feature flag overrides in page session: ${window.sessionStorage.getItem(storageKey)}`); + /* eslint-enable no-console */ }; // For local development only. Register feature flags for Staging and Production by @@ -23,6 +26,7 @@ window.APP_CONFIG.featureFlags = { newTerminologyEnabled: true, newGrantsDetailPageEnabled: true, shareTerminologyEnabled: true, + followNotesEnabled: true, }; // Setting a GOOGLE_TAG_ID enables Google Analytics. diff --git a/packages/client/src/helpers/featureFlags/index.js b/packages/client/src/helpers/featureFlags/index.js index 62fd2e074..5e330705d 100644 --- a/packages/client/src/helpers/featureFlags/index.js +++ b/packages/client/src/helpers/featureFlags/index.js @@ -11,3 +11,7 @@ export function newGrantsDetailPageEnabled() { export function shareTerminologyEnabled() { return getFeatureFlags().shareTerminologyEnabled === true; } + +export function followNotesEnabled() { + return getFeatureFlags().followNotesEnabled === true; +} \ No newline at end of file diff --git a/terraform/prod.tfvars b/terraform/prod.tfvars index 8b18df14b..17a30b9ab 100644 --- a/terraform/prod.tfvars +++ b/terraform/prod.tfvars @@ -51,6 +51,7 @@ website_feature_flags = { newTerminologyEnabled = true, newGrantsDetailPageEnabled = true, shareTerminologyEnabled = true, + followNotesEnabled = false, } // Google Analytics Account ID: 233192355, Property ID: 321194851, Stream ID: 3802896350 diff --git a/terraform/staging.tfvars b/terraform/staging.tfvars index 7461ffb94..0c903b4ac 100644 --- a/terraform/staging.tfvars +++ b/terraform/staging.tfvars @@ -50,6 +50,7 @@ website_feature_flags = { newTerminologyEnabled = true, newGrantsDetailPageEnabled = true, shareTerminologyEnabled = true, + followNotesEnabled = false, } // Google Analytics Account ID: 233192355, Property ID: 429910307, Stream ID: 7590745080 From b3b62514425c134a08877cf4b5943ac6e3423d21 Mon Sep 17 00:00:00 2001 From: Sushil Rajeeva Bhandary Date: Sat, 24 Aug 2024 03:06:07 -0400 Subject: [PATCH 2/3] eslint fix --- packages/client/src/helpers/featureFlags/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/client/src/helpers/featureFlags/index.js b/packages/client/src/helpers/featureFlags/index.js index 5e330705d..7fa1d4655 100644 --- a/packages/client/src/helpers/featureFlags/index.js +++ b/packages/client/src/helpers/featureFlags/index.js @@ -14,4 +14,4 @@ export function shareTerminologyEnabled() { export function followNotesEnabled() { return getFeatureFlags().followNotesEnabled === true; -} \ No newline at end of file +} From 95323fc815a84dec10138b678f68acb44fa65c9f Mon Sep 17 00:00:00 2001 From: Sushil Rajeeva Bhandary Date: Sat, 24 Aug 2024 03:19:56 -0400 Subject: [PATCH 3/3] terraform formatting fix --- terraform/prod.tfvars | 2 +- terraform/staging.tfvars | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/terraform/prod.tfvars b/terraform/prod.tfvars index 17a30b9ab..4933002ce 100644 --- a/terraform/prod.tfvars +++ b/terraform/prod.tfvars @@ -51,7 +51,7 @@ website_feature_flags = { newTerminologyEnabled = true, newGrantsDetailPageEnabled = true, shareTerminologyEnabled = true, - followNotesEnabled = false, + followNotesEnabled = false, } // Google Analytics Account ID: 233192355, Property ID: 321194851, Stream ID: 3802896350 diff --git a/terraform/staging.tfvars b/terraform/staging.tfvars index 0c903b4ac..e38ad49cd 100644 --- a/terraform/staging.tfvars +++ b/terraform/staging.tfvars @@ -50,7 +50,7 @@ website_feature_flags = { newTerminologyEnabled = true, newGrantsDetailPageEnabled = true, shareTerminologyEnabled = true, - followNotesEnabled = false, + followNotesEnabled = false, } // Google Analytics Account ID: 233192355, Property ID: 429910307, Stream ID: 7590745080