Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: v:20240702 upload validations #3365

Open
ClaireValdivia opened this issue Aug 8, 2024 · 1 comment
Open

[Issue]: v:20240702 upload validations #3365

ClaireValdivia opened this issue Aug 8, 2024 · 1 comment

Comments

@ClaireValdivia
Copy link
Contributor

ClaireValdivia commented Aug 8, 2024

Why is this issue important?

Treasury introduced several changes in July 2024. We have updated the input template to address these changes, and now need to update the upload validations to match the new requirements.

Current State

NA

Expected State

Updated input template

Version number
Set current version number as v:20240702
If a user uploads a file with that version number, there should be no warning. If a file is uploaded with a different version number, the warning message should generate: “Upload template version ([uploaded template version]) is [older/ newer] than the latest input template ([latest template version])”

Accept the following new fields and apply existing validations based on field type specified in the json

  • IAA_Basic_Conditions__c - note that this is a multi-select picklist
  • IAA_Requirements_Attestation__c
  • Personnel_Cost_Estimates__c
  • Personnel_Estimated_Expended
  • Personnel_Actual_Expended
  • Personnel_Expended_FTE_Count - additional validation here is that only whole integers should be accepted. if a decimal is entered, an error message should generate that says "A whole number must be submitted for this field."
  • Personnel_Expended_Justification
  • Contract_Estimated_Expended
  • Contract_Actual_Expended
  • Contract_Expended_Justification
  • Admin_Estimated_Expended__c
  • Admin_Actual_Expended__c
  • Admin_Expended_Description__c
  • Admin_Expended_Justification__c

These changes were made to Picklist values

  • Entity_Type_2__c - added picklist option “IAA” should be accepted
  • Award_Type__c - added picklist option "Interagency Agreement (IAA)" should be accepted
  • State_Abbreviated__c - added picklist option “Other” - allow this as a valid value and confirm that there is not anything preventing more than a 2-letter code for state picklist selection
  • Sub_Award_Type_Aggregates_SLFRF__c will have a new picklist selection of "Aggregate of Interagency Agreement (IAA)

Updates to UEI & TIN requirements:
Current state requirements are correct and should remain unchanged when entity type = contractor or subrecipient. However, the following changes should be made:

  • if IAA is selected as the entity type, UEI & TIN are both optional.
  • If Beneficiary is selected as the entity type, TIN is required and UEI is optional

Implementation Plan

The following functions need to be added...

Relevant Code Snippets

No response

@as1729
Copy link
Contributor

as1729 commented Aug 13, 2024

@ajhyndman looks like there are some tests looking for specific values in Entity field. Once those are fixed I can approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🚢 Completed
Development

No branches or pull requests

2 participants