Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep track of manual provider_location overrides #231

Closed
Mr0grog opened this issue Jun 16, 2021 · 1 comment · Fixed by #735
Closed

Keep track of manual provider_location overrides #231

Mr0grog opened this issue Jun 16, 2021 · 1 comment · Fixed by #735
Labels
api enhancement New feature or request good first issue Good for newcomers

Comments

@Mr0grog
Copy link
Collaborator

Mr0grog commented Jun 16, 2021

We have some situations where the database has manually entered data for provider locations, and we have to be very careful not to accidentally overwrite it. Instead, we should be tracking a list of manually overridden

One example of this is that NJVSS has some bad 4-digit zip codes, and they are manually fixed in our database. The NJVSS loader has to be very careful to check for bad zip codes so as not to overwrite what’s in that field in the DB: https://github.com/usdigitalresponse/appointment-availability-infra/blob/ce4c936107d2a449d530d41e7d24b5e32f68dffe/loader/src/sources/njvss/index.js#L402-L407

We could track manual overrides in a new DB table as part of #202, but it might be better (especially in the short term) to simply keep them in a file in our source code. Storing them in a source code file means they are easy to see, review, and update (and we multiple eyes on them via PRs). We don’t have any GUI that gives us a similarly clear window into overrides we might store in the database. (Props to @janovergoor for pointing this out.)

@Mr0grog Mr0grog added enhancement New feature or request good first issue Good for newcomers api labels Jun 16, 2021
@Mr0grog
Copy link
Collaborator Author

Mr0grog commented Jun 16, 2021

Zip codes that were overridden for NJVSS (we should start by having these in the overrides file):

Bad Zip Good Zip IIS ID Name
7505 07505 13354:CITYRX_PHARMACY "CityRX Pharmacy, 7 W Broadway, Paterson, NJ"
0703 07030 13289:HOBOKEN_FAMILY_PHARMACY "Hoboken Family Pharmacy, 307 1st Street, Hoboken, NJ"
8817 08817 10872:WALMART_5201 "Walmart 5201"
8087 08087 11280:WALMART_3830 "Walmart 3830"
7095 07095 10873:WALMART_5281 "Walmart 5281"
7836 07836 10904:WALMART_3291 "Walmart 3291"
7032 07032 10866:WALMART_5447 "Walmart 5447"
7852 07852 13184:WALMART_3912 "Walmart 3912"
7866 07866 10899:WALMART_5178 "Walmart 5178"
8096 08096 10924:WALMART_3422 "Walmart 3422"
7036 07036 10901:WALMART_3469 "Walmart 3469"
8857 08857 10862:WALMART_4153 "Walmart 4153"
8094 08094 10928:WALMART_3774 "Walmart 3774"
7083 07083 10903:WALMART_3292 "Walmart 3292"
8734 08734 10871:WALMART_5414 "Walmart 5414"
8096 08096 10930:WALMART/SAMS_6670 "Walmart/Sams 6670"
8094 08094 10929:WALMART/SAMS_4722 "Walmart/Sams 4722"
8232 08232 10931:WALMART/SAMS_8144 "Walmart/Sams 8144"
8817 08817 10868:WALMART/SAMS_6369 "Walmart/Sams 6369"
8077 08077 10932:WALMART/SAMS_8145 "Walmart/Sams 8145"
7728 07728 10870:WALMART/SAMS_6671 "Walmart/Sams 6671"
7094 07974 10896:WALMART/SAMS_4774 "Walmart/Sams 4774"
8863 08863 13341:AR-EX_PHARMACY "AR-EX PHARMACY"
7047 07047 752:NORTH_BERGEN_HEALTH_DEPARTMENT "NORTH BERGEN HEALTH DEPARTMENT"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant