-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imcomplete extract_metrics.py. #107
Comments
extract_metrics.py hasn't been updated in a long time, the script format itself is dated in comparison to the rest of the scripts. Is this currently in use for anything? If so, I can take a look at it, it shouldn't be hard to bring up to the standards of the rest of the scripts. |
@MarceloLaser Hi Marcelo, it's not urgent, but do please take a look at some point. Since the previous one was incomplete and didn't seem to be executable, I added some code to it to make it work but I'm not sure whether it's doing its job correctly. It will be helpful if you can take a look into it. |
I just had a look; what happened there is that I was tinkering with that script so much and had to re-run it so many times, I eventually just hard-coded a bunch of junk into it to "cut" the effective re-runs. Basically, right now that script is doing two things:
Ideally, those things should be separated into their own scripts. Also, because of the nature of metrics plotting, a lot of that script was experimental to create graphs that would look good, so it's a very "volatile" script. I'll clean it up a bit and push it back upstream to a new branch, but it should be tested before bringing it back down to master. I currently don't have my environment set up to do that, so it'll have to sit on the new branch until either I get my work computer back here, or someone else takes the time to run a few tests. |
extract_metrics.py has hard-coded subject system and no main entry for generate metric files.
The text was updated successfully, but these errors were encountered: