Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imcomplete extract_metrics.py. #107

Open
WGC575 opened this issue Nov 17, 2023 · 3 comments
Open

Imcomplete extract_metrics.py. #107

WGC575 opened this issue Nov 17, 2023 · 3 comments
Assignees

Comments

@WGC575
Copy link
Collaborator

WGC575 commented Nov 17, 2023

extract_metrics.py has hard-coded subject system and no main entry for generate metric files.

@WGC575 WGC575 self-assigned this Nov 17, 2023
WGC575 added a commit that referenced this issue Nov 17, 2023
@MarceloLaser
Copy link
Contributor

extract_metrics.py hasn't been updated in a long time, the script format itself is dated in comparison to the rest of the scripts. Is this currently in use for anything? If so, I can take a look at it, it shouldn't be hard to bring up to the standards of the rest of the scripts.

@WGC575
Copy link
Collaborator Author

WGC575 commented Nov 18, 2023

extract_metrics.py hasn't been updated in a long time, the script format itself is dated in comparison to the rest of the scripts. Is this currently in use for anything? If so, I can take a look at it, it shouldn't be hard to bring up to the standards of the rest of the scripts.

@MarceloLaser Hi Marcelo, it's not urgent, but do please take a look at some point. Since the previous one was incomplete and didn't seem to be executable, I added some code to it to make it work but I'm not sure whether it's doing its job correctly. It will be helpful if you can take a look into it.

@MarceloLaser
Copy link
Contributor

I just had a look; what happened there is that I was tinkering with that script so much and had to re-run it so many times, I eventually just hard-coded a bunch of junk into it to "cut" the effective re-runs. Basically, right now that script is doing two things:

  1. Actually extract the metrics.
  2. Plot a whole bunch of stuff from those metrics.

Ideally, those things should be separated into their own scripts. Also, because of the nature of metrics plotting, a lot of that script was experimental to create graphs that would look good, so it's a very "volatile" script.

I'll clean it up a bit and push it back upstream to a new branch, but it should be tested before bringing it back down to master. I currently don't have my environment set up to do that, so it'll have to sit on the new branch until either I get my work computer back here, or someone else takes the time to run a few tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants