Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# proto include dirs #894

Open
UnstoppableMango opened this issue Aug 6, 2021 · 1 comment
Open

C# proto include dirs #894

UnstoppableMango opened this issue Aug 6, 2021 · 1 comment

Comments

@UnstoppableMango
Copy link
Collaborator

Include dirs are kinda jank atm with having google apis as a submodule. Find some way to make it less jank. Could certainly be just symlinking the files we care about, but I want to at least look into it a little more before doing such jank.

Also at the time of creating this issue, it's only the C# that has jank imports, but I might have added more since then that need de-janking

@UnstoppableMango UnstoppableMango transferred this issue from unmango/safir-common Nov 17, 2021
@UnstoppableMango
Copy link
Collaborator Author

Went through a couple iterations since this was created. Tried Buf. Tried dotnet-grpc and gitignored the vendor files. Tried dotnet-grpc and checked in the vendor files. Now I don't think I even need manual intervention due to https://www.github.com/dotnet/aspnetcore/issues/43376.

Still would like to use Buf, but it's hard to get a workflow that works well locally and in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant