Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete files #87

Open
uhthomas opened this issue Oct 9, 2020 · 2 comments
Open

Delete files #87

uhthomas opened this issue Oct 9, 2020 · 2 comments

Comments

@uhthomas
Copy link
Owner

uhthomas commented Oct 9, 2020

Kipp does not currently expose any mechanism to request the deletion of files, which is a problem. The hard part is figuring out how to distribute deletion keys, as browsers don't allow the interception of redirects (which is how Kipp handles responses to uploads). A few ideas have come to mind:

  • Providing a key in the request.
  • Using cookies (which would fix the redirect problem).
  • Using authorization headers.

I don't want to get into a situation where keys aren't rotated, or get leaked however.

@uhthomas
Copy link
Owner Author

uhthomas commented Oct 9, 2020

Continuing from this - the cookie solution seems kind of nice, as path attributes can be specified.

@uhthomas
Copy link
Owner Author

uhthomas commented Dec 4, 2020

There is a second part to this, and that's cleaning up files. Kipp used to delete files by using an interval for which the database would be queried for expired files, and they would be removed from the database and storage. This is not scalable, and so had been removed, and currently files are stored forever (even if the database enforced a fixed TTL).

I believe the best way to approach this would be using a message queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant