Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better diagnostics and logging for failures of save_notebook #449

Open
davidwagner opened this issue Nov 8, 2021 · 1 comment
Open

Better diagnostics and logging for failures of save_notebook #449

davidwagner opened this issue Nov 8, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@davidwagner
Copy link

Is your feature request related to a problem? Please describe.
Currently the force-save implemented by grader.export(force_save=True) is flaky and we have observed it sometimes failing in Data 8. When it fails, the student sees the error message "AssertionError: Notebook project2.ipynb is empty. Please save and checkpoint your notebook and rerun this cell." We are having trouble identifying what is causing this failure.

Describe the solution you'd like
It would be useful to have more diagnostics about this. In particular:

  1. It'd be useful to get this error into the syslog logs that are visible in Google Cloud Platform logs, so we can track how often it occurs and when it occurs. Right now the error is displayed to the student but it is not logged.
  2. It would be useful to have additional logging about the cause of the problem. The relevant code calls IPython.display.display(IPython.display.Javascript("Jupyter.notebook.save_checkpoint();")), which is async, so any uncaught exceptions/errors will get swallowed. It would be nice to try to catch exceptions/errors and log them.

Additional context
#444,

def save_notebook(filename, timeout=10):

@stale
Copy link

stale bot commented Jan 7, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 7, 2022
@stale stale bot removed the wontfix This will not be worked on label Jan 7, 2022
@chrispyles chrispyles removed the pinned label May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants