Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy: garbage collection story #586

Open
bobheadxi opened this issue Feb 25, 2019 · 0 comments
Open

deploy: garbage collection story #586

bobheadxi opened this issue Feb 25, 2019 · 0 comments
Labels
:deploy daemon build and deploy functionality todo: investigate more research required
Milestone

Comments

@bobheadxi
Copy link
Member

bobheadxi commented Feb 25, 2019

Inertia's garbage collection right now is a weird mish-mash of "ill destroy assets whenever i feel like it". For example, Prune(), PruneAll() gets called at random places, and we dont have a good way of enforcing what gets deleted.

I'm thinking we introduce a package inertia/inertiad/daemon/gc, that is leveraged as a persistent goroutine to replace deployment.Watch(), to be dedicated to garbage collection, and in doing so make sure that no other part of the daemon deletes assets.

This will take a bit of planning to work out the best way to pull this off, and how to integrate it with work on #293 and #578

@bobheadxi bobheadxi added todo: investigate more research required :deploy daemon build and deploy functionality labels Feb 25, 2019
@bobheadxi bobheadxi added this to the v1.0.0 milestone Feb 25, 2019
@bobheadxi bobheadxi self-assigned this Feb 25, 2019
@bobheadxi bobheadxi modified the milestones: v1.0.0, next Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:deploy daemon build and deploy functionality todo: investigate more research required
Projects
None yet
Development

No branches or pull requests

2 participants